Fix attribute differences in between refs and implementations #40185
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Interop looks good.
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Thanks, @safern. Sorry about the mismatches.
Oh that is hard to catch without the tooling. I just wanted to give you an FYI in case we needed to port this to P8 or just do that you know some APIs missed it in case someone reports that when trying the analyzer 😄 |
|
FYI: @eerhardt |
src/libraries/System.Text.Json/src/MatchingRefApiCompatBaseline.txt
Outdated
Show resolved
Hide resolved
|
Merging since failures are unrelated and pending pipelines are not affected by this change and I want to avoid merge conflicts or people adding attributes in other PRs and missing those and having to update this PR. |
|
@safern thanks for catching and fixing all the issues! It's great that you have improved the tooling as well! |
…#40185) * Fix attribute differences in between refs and implementations * Update APICompat version and address feedback * Fix builds * PR Feedback, include attributes for all tfms in S.T.Json ref
| public partial class JsonConverterAttribute : System.Text.Json.Serialization.JsonAttribute | ||
| { | ||
| protected JsonConverterAttribute() { } | ||
| #if NETCOREAPP && !NETCOREAPP3_0 |
There was a problem hiding this comment.
Question: How come this was caught, but not the #if/def above
public static partial class JsonSerializer {
#if NETCOREAPP && !NETCOREAPP3_0
...There was a problem hiding this comment.
I think it was just my mistake when looking at the diff and I accidentally discarded that change and then gave it a thought but forgot to redo the removal.
ghost
locked as resolved and limited conversation to collaborators
11 participants
We noticed that a change in ApiCompat is causing ApiCompat to not check for difference in attributes. We're fixing that in: dotnet/arcade#5862
This reacts to that fix.