Rename MinimumOSPlatformAttribute and RemovedInOSPlatformAttribute#40371
Merged
Conversation
* MinimumOSPlatformAttribute -> SupportedOSPlatformAttribute * RemovedInOSPlatformAttribute -> UnsupportedOSPlatformAttribute
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
@krwq @eiriktsarpalis any chances I could get an approval from you during European working hours? this PR blocks me from fixing #40095 and I would prefer to send two separate PRs |
This was referenced Aug 5, 2020
krwq
approved these changes
Aug 5, 2020
Member
krwq
left a comment
krwq
left a comment
There was a problem hiding this comment.
Looks good, please fix build errors
Member
Author
|
the build failures seem unrelated, merging |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…otnet#40371) * rename attributes: * MinimumOSPlatformAttribute -> SupportedOSPlatformAttribute * RemovedInOSPlatformAttribute -> UnsupportedOSPlatformAttribute * update src and ref files * update .targets file * update comment ;)
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #40360
cc @terrajobst