Skip to content

Missed cases not discovered during the first phase #40382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aik-jahoda merged 1 commit into from
Aug 25, 2020
Merged

Missed cases not discovered during the first phase #40382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public abstract class PrincipalTest : IDisposable

private void RefreshContext()
{
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test dummy credentials.")]
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")]
string username = "Administrator", password = "Adrumble@6";

string OU = "Tests";
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.DirectoryServices.AccountManagement/tests/UserPrincipalTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public void UserPrincipalConstructorTest()

public void ComputedUACCheck()
{
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test dummy credentials.")]
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")]
string username = "Administrator", password = "Adrumble@6";
//TODO: don't assume it exists, create it if its not
string OU = "TestNull";
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Security.Cryptography.X509Certificates/tests/TestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ internal static class TestData
-----END CERTIFICATE-----
");

// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")]
public const string PfxDataPassword = "12345";

public static SecureString CreatePfxDataPasswordSecureString()
Expand Down Expand Up @@ -476,6 +477,7 @@ public static SecureString CreatePfxDataPasswordSecureString()
"313021300906052B0E03021A0500041466FD3518CEBBD69877BA663C9E8D7092" +
"8E8A98F30408DFB5AE610308BCF802020800").HexToByteArray();

// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")]
public const string Dsa1024PfxPassword = "1234";

public static byte[] Dsa1024Cert = (
Expand Down