Fixes for QUIC and HTTP/3 #40468
Merged
Fixes for QUIC and HTTP/3 #40468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition in MsQuicListener setting MsQuicConnection.Connected. Some MsQuic cleanup. Remove (un-reviewed) HttpVersion.Version30 and SslApplicationProtocol.Http3 APIs. Fix Alt-Svc support. Make Alt-Svc tests timeout properly.
|
Tagging subscribers to this area: @dotnet/ncl |
geoffkizer
reviewed
Aug 6, 2020
| { | ||
| SOCKADDR_INET inetAddress = MsQuicParameterHelpers.GetINetParam(MsQuicApi.Api, _ptr, (uint)QUIC_PARAM_LEVEL.CONNECTION, (uint)QUIC_PARAM_CONN.LOCAL_ADDRESS); | ||
| _localEndPoint = MsQuicAddressHelpers.INetToIPEndPoint(inetAddress); | ||
| if (!_connected) |
Contributor
There was a problem hiding this comment.
Can this ever happen when _connected is true? Should we assert and/or throw?
Contributor
Author
There was a problem hiding this comment.
This happens on the listener side -- MsQuic fires the connected event immediately after it fires the new connection accepted event.
geoffkizer
approved these changes
Aug 6, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
Update/fix MsQuic P/invoke layer. Fix a race condition in MsQuicListener setting MsQuicConnection.Connected. Some MsQuic cleanup. Remove (un-reviewed) HttpVersion.Version30 and SslApplicationProtocol.Http3 APIs. Fix Alt-Svc support. Make Alt-Svc tests timeout properly.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MsQuic P/Invoke layer to latest version.
Fix a race condition in MsQuicListener setting MsQuicConnection.Connected.
Some MsQuic cleanup.
Remove (un-reviewed and not yet standard) HttpVersion.Version30 and SslApplicationProtocol.Http3 APIs.
Fix Alt-Svc support and tests.