Skip to content

Re-enable testing on OSX 10.15 #40524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
directhex merged 5 commits into from
Aug 24, 2020
Merged

Re-enable testing on OSX 10.15 #40524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
153a541
Re-enable testing on OSX 10.15, add 11.0
directhex Aug 7, 2020
a6c1204
whoops
directhex Aug 7, 2020
613f651
Actually, test on 2 latest for PRs (all supported in fullmatrix)
directhex Aug 10, 2020
8dd3de0
Merge remote-tracking branch 'origin/master' into test-on-catalina
directhex Aug 17, 2020
63836ee
ActiveIssue for failing font issue
directhex Aug 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions eng/pipelines/libraries/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,10 @@ jobs:
- ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}:
- OSX.1013.Amd64.Open
- OSX.1014.Amd64.Open
# The 10.15 machines aren't in the same configuration, see
# https://github.com/dotnet/runtime/issues/24736
#- OSX.1015.Amd64.Open
- OSX.1015.Amd64.Open
Comment thread
directhex marked this conversation as resolved.
- ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}:
- OSX.1013.Amd64.Open
- OSX.1014.Amd64.Open
- OSX.1015.Amd64.Open

# Windows_NT x64
- ${{ if eq(parameters.platform, 'Windows_NT_x64') }}:
Expand Down
4 changes: 4 additions & 0 deletions src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ public void Equals_Object_ReturnsExpected(FontFamily fontFamily, object other, b
}
}

// This will fail on any platform we use libgdiplus, with any
// installed system fonts whose name is longer than 31 chars.
// macOS 10.15+ ships out of the box with a problem font
[ActiveIssue("https://github.com/dotnet/runtime/issues/40937", TestPlatforms.AnyUnix)]
[ConditionalFact(Helpers.IsDrawingSupported)]
public void Families_Get_ReturnsExpected()
{
Expand Down