Skip to content

Unconditionally expand some of the Vector128 methods on x86/x64 #40688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Aug 13, 2020
Merged

Unconditionally expand some of the Vector128 methods on x86/x64 #40688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/coreclr/src/zap/zapinfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2176,6 +2176,30 @@ DWORD FilterNamedIntrinsicMethodAttribs(ZapInfo* pZapInfo, DWORD attribs, CORINF
fTreatAsRegularMethodCall |= !fIsPlatformHWIntrinsic && fIsHWIntrinsic
&& (strncmp(className, "Vector64", _countof("Vector64") - 1) != 0)
&& (strncmp(className, "Vector128", _countof("Vector128") - 1) != 0);

#elif defined(TARGET_X86) || defined(TARGET_AMD64)
// The following methods should be safe to expand unconditionally, since JIT either
// 1) does not generate code for them (e.g. for Vector128<T>.AsByte() or get_Count) or
// 2) uses instructions that belong to Sse or Sse2 (these are required baseline ISAs).
static const char* vector128MethodsSafeToExpand[] = { "As", "AsByte", "AsDouble", "AsInt16", "AsInt32", "AsInt64", "AsSByte",
"AsSingle", "AsUInt16", "AsUInt32", "AsUInt64", "Create", "CreateScalarUnsafe", "ToScalar", "get_Count", "get_Zero" };

if (!fIsPlatformHWIntrinsic && fIsHWIntrinsic)
{
fTreatAsRegularMethodCall = true;

if (strncmp(className, "Vector128", _countof("Vector128") - 1) == 0)
{
for (size_t i = 0; i < _countof(vector128MethodsSafeToExpand); i++)
{
if (strcmp(methodName, vector128MethodsSafeToExpand[i]) == 0)
{
fTreatAsRegularMethodCall = false;
break;
}
}
}
}
#else
fTreatAsRegularMethodCall |= !fIsPlatformHWIntrinsic && fIsHWIntrinsic;
#endif
Expand Down