Skip to content

[mono] Add X86Base support. #40861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imhameed merged 4 commits into from
Aug 17, 2020
Merged

[mono] Add X86Base support. #40861

imhameed merged 4 commits into from
Aug 17, 2020

Conversation

@imhameed
Copy link
Contributor

@imhameed imhameed commented Aug 14, 2020

Implement BitScanForward and BitScanReverse as intrinsics.

Implement __cpuidex as a netcore-only icall. Rename cpuid (in
mono-hwcap-x86.c) to mono_cpuidex, give it extern linkage, and add
support for extended CPUID.

Related: #40167

@imhameed
[mono] Add X86Base support.
2b0c71d 
Implement `BitScanForward` and `BitScanReverse` as intrinsics.

Implement `__cpuidex` as a netcore-only icall. Rename `cpuid` (in
mono-hwcap-x86.c) to `mono_cpuidex`, give it extern linkage, and add
support for extended CPUID.

Related: dotnet#40167
@monojenkins monojenkins mentioned this pull request Aug 14, 2020
Merged
jaykrell
jaykrell reviewed Aug 15, 2020
View reviewed changes
@ghost
Copy link

ghost commented Aug 15, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

CoffeeFlux
CoffeeFlux reviewed Aug 16, 2020
View reviewed changes
@imhameed
Use 64-bit constants when xoring the result of a 64-bit ctlz.
d5a9b09 
Address feedback: remove the size from some local array definitions, and
hide ves_icall_System_Runtime_Intrinsics_X86_X86Base___cpuidex behind
TARGET_AMD64.
@imhameed imhameed force-pushed the x86base-intrinsics branch from 29ae3b9 to d5a9b09 Compare August 17, 2020 06:42
@imhameed imhameed merged commit 1fb34e7 into dotnet:master Aug 17, 2020
@akoeplinger
Copy link
Member

akoeplinger commented Aug 20, 2020

@imhameed this causes a new warning during the build:

  /Users/alexander/dev/runtime2/src/mono/mono/utils/mono-hwcap-x86.c:33:1: warning: no previous prototype for function 'mono_cpuidex' [-Wmissing-prototypes]
  mono_cpuidex (int id, int sub_id, int *p_eax, int *p_ebx, int *p_ecx, int *p_edx)
  ^
  /Users/alexander/dev/runtime2/src/mono/mono/utils/mono-hwcap-x86.c:32:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  gboolean
  ^
  static
  1 warning generated.

@imhameed
Copy link
Contributor Author

imhameed commented Aug 21, 2020

Whoops. I'll take care of it.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaykrell jaykrell jaykrell left review comments

@EgorBo EgorBo EgorBo approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@lambdageek lambdageek Awaiting requested review from lambdageek

@marek-safar marek-safar Awaiting requested review from marek-safar

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@steveisok steveisok Awaiting requested review from steveisok

@thaystg thaystg Awaiting requested review from thaystg

+2 more reviewers

@CoffeeFlux CoffeeFlux CoffeeFlux left review comments

@vargaz vargaz vargaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@imhameed @akoeplinger @vargaz @EgorBo @jaykrell @CoffeeFlux @jkotas @Dotnet-GitSync-Bot