Ensure we test packages for browser #41041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @safern, @ViktorHofer |
Anipik
approved these changes
Aug 19, 2020
safern
approved these changes
Aug 19, 2020
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
I guess we're going to add this to arcade?
Member
Author
|
We can, I just wanted to get coverage quickly first. |
joperezr
approved these changes
Aug 19, 2020
Member
Author
layomia
reviewed
Aug 20, 2020
src/installer/managed/Microsoft.NET.HostModel/ComHost/ClsidMap.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Layomi Akinrinade <layomia@gmail.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we hit an issue where System.Drawing.Common had a ref-def mismatch when consumed on browser.
This change adds testing for browser to our package validation. Mainly I'm doing this as a sanity check for our packages. Longer term I'd like to improve how we validate packages to avoid RID-specific restores.