Add DO-NOT-SIGN comment for files that should not be signed#41185
Merged
NikolaMilosavljevic merged 1 commit intodotnet:masterfrom Aug 22, 2020
Merged
Add DO-NOT-SIGN comment for files that should not be signed#41185NikolaMilosavljevic merged 1 commit intodotnet:masterfrom
NikolaMilosavljevic merged 1 commit intodotnet:masterfrom
Conversation
dagood
approved these changes
Aug 21, 2020
safern
approved these changes
Aug 21, 2020
Member
Author
|
@safern do you know if the failing run is a known issue? It seems to be failing in all recent PRs.
|
Member
|
Yes #41215 |
Member
Author
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/220034616 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infrastructure change to flag files that are signed, but shouldn't like apphost/comhost.
Fixes: #3748
Uses Arcade infra added in 2019: dotnet/arcade#4058