Nullability annotations for HttpListener #41189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2020 15:33
|
Tagging subscribers to this area: @dotnet/ncl |
lindexi
reviewed
Aug 22, 2020
src/libraries/System.Net.HttpListener/src/System/Net/HttpListenerRequest.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Aug 22, 2020
src/libraries/System.Net.HttpListener/src/System/Net/Managed/ListenerAsyncResult.Managed.cs
Outdated
Show resolved
Hide resolved
aik-jahoda
reviewed
Aug 25, 2020
src/libraries/System.Net.HttpListener/src/System/Net/HttpListenerRequest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpConnection.cs
Show resolved
Hide resolved
src/libraries/System.Net.HttpListener/src/System/Net/Managed/ListenerAsyncResult.Managed.cs
Outdated
Show resolved
Hide resolved
14 tasks
| int length = (int)_memoryStream.Length; | ||
| byte[] buffer = _memoryStream!.GetBuffer(); | ||
| int length = (int)_memoryStream!.Length; | ||
| _memoryStream = null; |
Contributor
There was a problem hiding this comment.
@aik-jahoda shouldn't we call _memoryStream.Dispose() here? I find it weird that it is being set to null.
I ask because this is what forced Prashanth to make _memoryStream nullable.
Contributor
There was a problem hiding this comment.
I wouldn't change behaviour now but create follow up work for .NET 6. I'm fine with nullable _memoryStream since we have this discussion recorder here for future fix.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @aik-jahoda @jozkee @krwq