Add sleep in hijacking test #41340
Merged
Add sleep in hijacking test #41340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jakobbotsch
changed the title
Calling GC.Collect in a tight loop is unnecessary for the test and causing timeouts in CI. Fixes dotnet#40916
jakobbotsch
force-pushed
the
hijacking-sleep
branch
from
06688c2 to
6815aba
Compare
jkotas
added
area-CodeGen-coreclr
Member
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/224428212 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling GC.Collect in a tight loop is unnecessary for the test and
causing timeouts in CI.
Fixes #40916
I have verified that this test still catches the regression if the following is commented:
runtime/src/coreclr/src/vm/threads.h
Lines 4124 to 4129 in ff4f37f