Skip to content

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Aug 27, 2020

Fixup for #40914. More detail in #41366 (comment).

  • Prevents test issues due to non-deterministic reflection order on serialization.
  • Prevents a ~6% throughput regression when using custom converters on deserialization.

@layomia layomia added this to the 5.0.0 milestone Aug 27, 2020
@layomia layomia self-assigned this Aug 27, 2020
@devsko
Copy link
Contributor

devsko commented Aug 27, 2020

Sorry, didn't know JsonTestHelper.

@layomia layomia changed the title Fixup JSON equality checks in polymorphic converter tests Clean up changes in #40914 Aug 27, 2020
@layomia
Copy link
Contributor Author

layomia commented Aug 27, 2020

Sorry, didn't know JsonTestHelper.

No worries at all!

@layomia layomia force-pushed the polymorphic_converter_test_fixup branch from 7f6857b to 3141b60 Compare August 27, 2020 21:16
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@layomia
Copy link
Contributor Author

layomia commented Aug 27, 2020

Test failure: #41485.

@layomia layomia added NO-SQUASH The PR should not be squashed and removed NO-SQUASH The PR should not be squashed labels Aug 27, 2020
@layomia layomia merged commit fb753ae into dotnet:master Aug 27, 2020
@layomia layomia deleted the polymorphic_converter_test_fixup branch August 27, 2020 22:55
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants