-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Clean up changes in #40914 #41427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
layomia
merged 2 commits into
dotnet:master
from
layomia:polymorphic_converter_test_fixup
Aug 27, 2020
Merged
Clean up changes in #40914 #41427
layomia
merged 2 commits into
dotnet:master
from
layomia:polymorphic_converter_test_fixup
Aug 27, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry, didn't know |
Contributor
Author
No worries at all! |
ericstj
reviewed
Aug 27, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfo.cs
Outdated
Show resolved
Hide resolved
ericstj
approved these changes
Aug 27, 2020
7f6857b to
3141b60
Compare
ericstj
approved these changes
Aug 27, 2020
jozkee
approved these changes
Aug 27, 2020
Member
jozkee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
Contributor
Author
|
Test failure: #41485. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #40914. More detail in #41366 (comment).