Skip to content

Conversation

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Sep 3, 2020

Clean up items found when doing #41476

  • Remove DiagnosticUtility.IsFatal, which always returns false.
  • Remove dead CreateDelegate method
  • Fix a TODO-NULLABLE where MemberInfo will never be null
  • Clean up remaining #if USE_REFEMIT and other unused defines in DataContractSerialization

- Remove DiagnosticUtility.IsFatal, which always returns false.
- Remove dead CreateDelegate method
- Fix a TODO-NULLABLE where MemberInfo will never be null
Copy link
Member

@StephenMolloy StephenMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eerhardt eerhardt merged commit a196d53 into dotnet:master Sep 4, 2020
@eerhardt eerhardt deleted the DataContractSerializationCleanup branch September 4, 2020 13:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants