Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Sep 4, 2020

Fixes: #3619

Update of THIRD-PARTY-NOTICES file for 5.0 release.

Generated using infra implemented by @dagood : #41695

Dependent repos were uncovered from .NET 5.0 graph dependencies. Individual third-party-notices were automatically consumed from the following repos and merged into dotnet/runtime file:

dotnet/aspnetcore
dotnet/diagnostics
dotnet/installer
dotnet/roslyn-analyzers
dotnet/templating
dotnet/winforms
dotnet/wpf

The following repos did not have any third-party-notices files, so they could not be processed:

dotnet/efcore
dotnet/extensions
dotnet/icu
dotnet/sdk
dotnet/windowsdesktop
mono/linker

@nakarnam can you add repo owners as reviewers of this PR? We need them to review and approve the changes.

Note that there are 2 commits, one introduces a new copy of THIRD-PARTY-NOTICES file for deployment with shared host installer; the other has updates for 5.0 release. Teams can review additions or file in its entirety.

@danmoseley
Copy link
Member

@ajcvickers is it correct that dotnet/efcore does not need a third party notices?

@ajcvickers
Copy link
Contributor

@danmosemsft We depend on third-party packages, but we don't ship in .NET, only as NuGet packages. This was something Eilon used to take care of. @Pilchie Do you know what we need to do here, if anything?

@danmoseley
Copy link
Member

@ajcvickers right, it may not be relevant to the installer but I was wondering whether a https://github.com/dotnet/efcore/blob/master/THIRD-PARTY-NOTICES.TXT ought to exist or was overlooked. just checking in case

@ajcvickers
Copy link
Contributor

@danmosemsft Thanks Dan. I suspect it should exist; I will follow up.

@NikolaMilosavljevic
Copy link
Member Author

Merging this PR as most of the reviewers have signed off or given sufficient time for review.

@NikolaMilosavljevic NikolaMilosavljevic merged commit 74fe95b into dotnet:master Oct 2, 2020
@NikolaMilosavljevic
Copy link
Member Author

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2020

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/284864684

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review and update THIRD-PARTY-NOTICES.TXT