[release/5.0-rc2] Force concurrent LdapConnection in new process #41951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenLDAP requires a single call for initialization before any other concurrent call. This fixes asserts and segfaults we were seeing when calling OpenLDAP concurrently.
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley |
Member
|
I'll take this can you fill in the template? |
danmoseley
reviewed
Sep 8, 2020
danmoseley
approved these changes
Sep 8, 2020
leecow
added
Servicing-approved
Member
|
Ran the functional tests and confirmed no regression. Merging. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41880 to release/5.0-rc2
/cc @ericstj
Customer Impact
Crash in application upon first use of System.DirectoryServices.Protocols on linux if multiple calls occur from different threads.
Testing
Stress testing before / after change to confirm issue has been addressed. Functional testing to ensure no regression with real server.
Risk
Low risk. A static constructor was introduced and a single call to get property.