Skip to content

Conversation

@yujinnee
Copy link
Contributor

@yujinnee yujinnee commented Sep 9, 2020

Fixes #38949

Removed OperationAbortedException because it was moved out of System.Data into SqlClient and so the testing belongs in the M.D.SqlClient repo. Other serialization tests for SQLClient types remain in this repo ,so I didn't removed them.

@ghost
Copy link

ghost commented Sep 9, 2020

Tagging subscribers to this area: @cheenamalhotra, @David-Engel
See info in area-owners.md if you want to be subscribed.

@@ -1,3 +1,4 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please undo this whitespace change?

@jkotas
Copy link
Member

jkotas commented Sep 9, 2020

You should be also able to delete reference to System.Data.SqlClient from the project file.

@yujinnee
Copy link
Contributor Author

@jkotas I deleted white space and reference to System.Data.SqlClient!

@danmoseley
Copy link
Member

Why remove this and not tests in the same file for eg SqlException?

@yujinnee
Copy link
Contributor Author

@danmosemsft I referred to this comment. Can it be a proper answer to your question??

@jkotas
Copy link
Member

jkotas commented Sep 10, 2020

@jkotas
Copy link
Member

jkotas commented Sep 10, 2020

Also, the build errors suggest that there are more SqlClient-related types that should be deleted from this test.

@danmoseley
Copy link
Member

@danmosemsft I referred to this comment. Can it be a proper answer to your question??

I'm guessing @Wraith2 was suggesting that we remove tests for all types that no longer exist in this repo. There are many of these unfortunately -- you can see which files were deleted in this PR: https://github.com/dotnet/runtime/pull/2275/files

I don't know a systematic way to find tests for them, but it would be good if you're willing in this PR to remove tests from this file for types named SqlXXXX that you see deleted in the above PR. Thanks!

@dnfadmin
Copy link

dnfadmin commented Sep 11, 2020

CLA assistant check
All CLA requirements met.

@jkotas
Copy link
Member

jkotas commented Sep 11, 2020

@yujinnee
Copy link
Contributor Author

To delete that reference, should I also remove the serialization tests related to SQLClinet type in other cs file in System.Runtime.Serialization.Formatters/tests ?

@Wraith2
Copy link
Contributor

Wraith2 commented Sep 11, 2020

Yes, anything that needs SqlClient can be removed. Anything which only needs System.Data.Common can be retained.

@jkotas jkotas merged commit 4198f71 into dotnet:master Dec 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Serialization tests for SQLClient types now that they no longer live in the dotnet/runtime repo

6 participants