-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Removed Serialization tests for SQLClient types #42016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @cheenamalhotra, @David-Engel |
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please undo this whitespace change?
|
You should be also able to delete reference to System.Data.SqlClient from the project file. |
|
@jkotas I deleted white space and reference to System.Data.SqlClient! |
|
Why remove this and not tests in the same file for eg SqlException? |
|
@danmosemsft I referred to this comment. Can it be a proper answer to your question?? |
|
Also, the build errors suggest that there are more SqlClient-related types that should be deleted from this test. |
I'm guessing @Wraith2 was suggesting that we remove tests for all types that no longer exist in this repo. There are many of these unfortunately -- you can see which files were deleted in this PR: https://github.com/dotnet/runtime/pull/2275/files I don't know a systematic way to find tests for them, but it would be good if you're willing in this PR to remove tests from this file for types named SqlXXXX that you see deleted in the above PR. Thanks! |
|
Could you please also delete SqlClient references from https://github.com/dotnet/runtime/blob/master/src/libraries/System.Runtime.Serialization.Formatters/tests/System.Runtime.Serialization.Formatters.Tests.csproj#L40 ? |
|
To delete that reference, should I also remove the serialization tests related to SQLClinet type in other cs file in System.Runtime.Serialization.Formatters/tests ? |
|
Yes, anything that needs SqlClient can be removed. Anything which only needs System.Data.Common can be retained. |
Fixes #38949
Removed OperationAbortedException because it was moved out of System.Data into SqlClient and so the testing belongs in the M.D.SqlClient repo. Other serialization tests for SQLClient types remain in this repo ,so I didn't removed them.