Fixing TargetHasAVXSupportCheck to read ECX not EDX #42089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
CarolEidt
approved these changes
Sep 10, 2020
| const int CPUID_EAX = 0; | ||
| const int CPUID_EBX = 1; | ||
| const int CPUID_ECX = 2; | ||
| const int CPUID_EDX = 3; |
Contributor
There was a problem hiding this comment.
Excellent - anything to improve the readability of this stuff!
|
Hello @tannergooding! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Member
Author
|
/backport to release/5.0-rc2 |
Contributor
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/248954289 |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC. @CarolEidt, as per https://github.com/dotnet/runtime/pull/40167/files#r486571424