Delete unused multibyte methods from PAL#42157
Merged
jkotas merged 1 commit intodotnet:masterfrom Sep 13, 2020
am11:feature/cleanup/pal/multibyte
Merged
Delete unused multibyte methods from PAL#42157jkotas merged 1 commit intodotnet:masterfrom am11:feature/cleanup/pal/multibyte
jkotas merged 1 commit intodotnet:masterfrom
am11:feature/cleanup/pal/multibyte
Conversation
Member
Author
|
cc @jkotas, this PR has not removed the |
am11
commented
Sep 12, 2020
jkotas
reviewed
Sep 12, 2020
jkotas
reviewed
Sep 12, 2020
jkotas
reviewed
Sep 12, 2020
jkotas
approved these changes
Sep 13, 2020
Member
|
@am11 Could you hold off on checking in any more changes that reformat code in the PAL tests for a week or so? My larger work item to return these tests to running in CI is running into repeated merge conflicts. Thank you. |
Member
Author
|
Sure, sorry about the conflicts. I just realize it (few hours ago, #42049 (comment)). :( #!/usr/bin/env sh
# assuming remote name 'dotnet' is present (after user/org GH naming)
# git remote dotnet https://github.com/dotnet/runtime
# if file exists in (combined) delta, clear the trailing white-spaces:
$ git show --name-only --pretty="" HEAD...dotnet/master |\
xargs -I{} sh -c "test -f {} && sed -i '' 's/[[:space:]]*$//' {}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateProcessAhad an occurrence in ToolBox, whereLPSTRwas converted toLPWSTR.