Re-enable CoreLib analyzers #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreLib analyzers were unintentionally disabled with 6afe96c. This re-enables the analyzers and conditions one which brings in external dependencies that CoreLib can't deal with.
stephentoub
reviewed
Dec 1, 2019
jkotas
reviewed
Dec 1, 2019
Member
Author
|
I'll remove that package as its description clearly state that it shouldn't be referenced directly. @safern do you have context why that package was referenced directly in corefx/arcade? |
Microsoft.CodeAnalysis.Common shouldn't be referenced directly, therefore removing that package from the common location and only restoring and marking it as an analyzer in the libraries restore phase.
Member
Author
|
OK, so the transitive dependency to Microsoft.CodeAnalysis.Common is required becaues of the special way we add analyzers to projects in libraries. We will clean this up with @Anipik's work to enable project restore for non test projects in libraries. |
jkotas
reviewed
Dec 2, 2019
jkotas
reviewed
Dec 2, 2019
Member
Author
|
This should be ready, can someone pls approve? Thanks |
stephentoub
approved these changes
Dec 2, 2019
Member
Author
|
Thanks, merging as the previous run was green (except an unrelated test failure) and I just changed a comment which re-triggered CI. |
safern
pushed a commit
that referenced
this pull request
Dec 3, 2019
* Re-enable CoreLib analyzers CoreLib analyzers were unintentionally disabled with 6afe96c. This re-enables the analyzers. * Remove Microsoft.CodeAnalysis.Common from common Microsoft.CodeAnalysis.Common shouldn't be referenced directly, therefore removing that package from the common location and only restoring and marking it as an analyzer in the libraries restore phase.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreLib analyzers were unintentionally disabled with
6afe96c. This re-enables the analyzers
and conditions one which brings in external dependencies that CoreLib
can't deal with.
Fixes #422