Skip to content

Make nullable-related checks consistent and faster #42401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steveharter merged 2 commits into from
Sep 23, 2020
Merged

Make nullable-related checks consistent and faster #42401

steveharter merged 2 commits into from
Sep 23, 2020

Conversation

@steveharter
Copy link
Contributor

@steveharter steveharter commented Sep 17, 2020 •
edited
Loading

Based on feedback and timings from #42319, updated other areas in STJ to use a faster way to check for nullability.

Ran existing benchmarks locally and these changes didn't measurably affect performance; see the micro benchmarks from the PR linked above.

@steveharter steveharter added this to the 6.0.0 milestone Sep 17, 2020
@steveharter steveharter requested a review from layomia September 17, 2020 20:08
@steveharter steveharter requested a review from jozkee as a code owner September 17, 2020 20:08
@steveharter steveharter self-assigned this Sep 17, 2020
layomia
layomia approved these changes Sep 21, 2020
View reviewed changes
@dotnet dotnet deleted a comment from layomia Sep 22, 2020
@steveharter
Copy link
Contributor Author

steveharter commented Sep 23, 2020

Test failures appear unrelated -- 3 timeouts:

  • runtime (Build Browser wasm Release AllSubsets_Mono) Cancelled after 120m — Build Browser wasm Release AllSubsets_Mono was canceled
  • runtime (Libraries Test Run release coreclr Linux x64 Debug) Cancelled after 150m — Libraries Test Run release coreclr Linux x64 Debug was canceled
  • runtime (Libraries Test Run release mono Linux x64 Debug) Cancelled after 150m — Libraries Test Run release mono Linux x64 Debug was canceled

@steveharter steveharter merged commit 98fc7ed into dotnet:master Sep 23, 2020
@steveharter steveharter deleted the Nullable branch September 23, 2020 14:52
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jozkee jozkee Awaiting requested review from jozkee

1 more reviewer

@layomia layomia layomia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steveharter steveharter

Labels

area-System.Text.Json tenet-performance Performance related issue

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@steveharter @layomia