-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Replace VerifyWithRevocation test with DynamicRevocationTests #42687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley |
|
Some justification: I ran |
...ystem.Security.Cryptography.X509Certificates/tests/RevocationTests/DynamicRevocationTests.cs
Show resolved
Hide resolved
|
This could use an outerloop run when anyone has a moment: |
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
None of the failures in HTTP (which look to be various kinds of timeouts) should have been caused by this test-only change (at least, it's not obvious that the timeouts are caused by some sort of automagical call to RevocationResponder.Stop()), so merging. |
VerifyWithRevocationis a flaky test. It needs internet to contact a CA for CRL/AIA and can occasionally fail. This replaces the offline revocation checking part of that test withDynamicChainTestswhich use our own local CA.Fixes #41952