[threads] Switch foreign threads to GC Safe in mono_thread_detach #42758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monojenkins
requested review from
BrzVlad,
CoffeeFlux,
SamMonoRT,
lambdageek,
lateralusX,
marek-safar,
thaystg and
vargaz
as code owners
monojenkins
force-pushed
the
sync-pr-20435-from-mono
branch
8 times, most recently
from
76f1998 to
84e3094
Compare
Member
|
@lateralusX I pushed f6e9c01 into this PR to add a call in EventPipe to |
Member
|
@lambdageek don't worry about that at the moment, as part of #41872 I pushed these methods into support methods that are already hooked up to the function table, so depending on what PR that get merged first we just need to adjust call within that function, eventpipe_thread_attach. |
monojenkins
force-pushed
the
sync-pr-20435-from-mono
branch
from
f6e9c01 to
f6dfe35
Compare
This was referenced Sep 30, 2020
monojenkins
force-pushed
the
sync-pr-20435-from-mono
branch
from
078c2d8 to
ff2f4f9
Compare
Addresses mono/mono#20290 and mono/mono#20283 If a foreign thread (that was created outside the runtime) calls `mono_thread_detach`, leave it in a preemptively-suspendable state, since we can't expect it to coop suspend. Conversely in `mono_thread_attach` (external only), ensure that we always leave the thread in GC Unsafe (aka RUNNING) state, for cases like while (cond) { t = mono_thread_attach (domain); <...> mono_thread_detach (t); } --- To make this work, we also make `mono_thread_detach` and `mono_thread_attach` external only. The runtime should use `mono_thread_internal_detach` and `mono_thread_internal_attach`.
monojenkins
force-pushed
the
sync-pr-20435-from-mono
branch
from
d071f85 to
a4f30d5
Compare
Member
|
The (Libraries Test Run release mono Linux x64 Debug) failure in SetDateTimeMax is due to #43166 |
lambdageek
approved these changes
Oct 8, 2020
This was referenced Oct 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! This PR is a copy of mono/mono#20435, please do not edit or review it in this repo !!
Do not automatically approve this PR:
* Consider how the changes affect configurations in this repo,
* Check effects on files that are not mirrored,
* Identify test cases that may be needed in this repo.
!! Merge the PR only after the original PR is merged !!
Addresses mono/mono#20290 and mono/mono#20283
If a foreign thread (that was created outside the runtime) calls
mono_thread_detach, leave it in a preemptively-suspendable state, since we can't expect it to coop suspend.Conversely in
mono_thread_attach(external only), ensure that we always leavethe thread in GC Unsafe (aka RUNNING) state, for cases like
To make this work, we also make
mono_thread_detachandmono_thread_attachexternal only. The runtime should usemono_thread_internal_detachandmono_thread_internal_attach.