[release/5.0] make sure we process PhysicalAddress on Linux #42882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley |
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
approved these changes
Sep 30, 2020
Member
|
I updated the temple and tests are green. This should be ready for Tactics @danmosemsft |
Member
|
@karelz are you supportive? |
Member
|
mailed |
geoffkizer
approved these changes
Sep 30, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42878 to release/5.0
/cc @wfurt
Customer Impact
NetworkInformation has API to get information about networking interfaces and their properties. PhysicalAddress is one of them and it is currently always empty because of 5.0 regression. This is simple omission e.g. we gathered the data from OS but we failed to put it to NetworkInterface object. This is Linux specific and does not impact other OSes
Testing
networking tests were updated to prevent this in future as well as we run customer repro code.
Risk
small