-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Remove pr: none clause from several CoreCLR pipelines #42933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 6 * * *" | ||
| displayName: Mon through Sun at 10:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 6 * * 0,1" | ||
| displayName: Sat and Sun at 10:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 7 * * 0,2,4" | ||
| displayName: Sun, Tue, Thu at 11:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 6 * * *" | ||
| displayName: Mon through Sun at 10:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 19 * * 6" | ||
| displayName: Sat at 11:00 AM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 22 * * 0,6" | ||
| displayName: Sun at 2:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 2 * * 0,1" | ||
| displayName: Sat and Sun at 6:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 5 * * *" | ||
| displayName: Mon through Sun at 9:00 PM (UTC-8:00) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| trigger: none | ||
|
|
||
| pr: none | ||
|
|
||
| schedules: | ||
| - cron: "0 13 * * 6,0" | ||
| displayName: Sat and Sun at 5:00 AM (UTC-8:00) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever want this pipeline to be triggerable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is that the outerloop pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ci.yml corresponds to the "runtime-coreclr outerloop" pipeline. I think we should rename the YAML script to "outerloop.yml", this is an endless cause of confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed to rename it before as well. However, if we rename it now, we will need to port that to release/5.0 and release/5.0-rc2 branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just busywork. I would say let's leave this for a more suitable time when there are no porting concerns.