Skip to content

[interp] Fold "ldstr".Length to a constant #43945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EgorBo wants to merge 2 commits into from
Closed

[interp] Fold "ldstr".Length to a constant #43945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0db5d
Fold "ldstr".Length to a const
EgorBo Oct 28, 2020
fef6f6d
Update transform.c
EgorBo Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/mono/mono/mini/interp/transform.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,8 +1629,19 @@ interp_handle_intrinsics (TransformData *td, MonoMethod *target_method, MonoClas
if (tm [0] == 'g') {
if (strcmp (tm, "get_Chars") == 0)
*op = MINT_GETCHR;
else if (strcmp (tm, "get_Length") == 0)
else if (strcmp(tm, "get_Length") == 0) {
// try to fold "ldstr".get_Length into a constant
if (td->last_ins && td->last_ins->opcode == MINT_LDSTR && interp_ip_in_cbb(td, td->ip - td->il_code)) {
MonoString* str = (MonoString*)td->data_items[td->last_ins->data[0]];
g_assert(str && str->length >= 0);
interp_clear_ins(td->last_ins);
interp_get_ldc_i4_from_const(td, NULL, str->length);
SET_SIMPLE_TYPE(td->sp - 1, STACK_TYPE_I4);
td->ip += 5;
return TRUE;
}
*op = MINT_STRLEN;
}
}
} else if (type_index >= 0) {
return interp_handle_magic_type_intrinsics (td, target_method, csignature, type_index);
Expand Down