Skip to content

ConcurrentQueueSegment allows spinning threads to sleep. #44265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 4 commits into from
Nov 5, 2020
Merged

ConcurrentQueueSegment allows spinning threads to sleep. #44265

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d323143
Allow threads to sleep when ConcurrentQueue has many enqueuers/dequeu…
alexcovington Nov 4, 2020
781dc6b
Merge branch 'master' of https://github.com/dotnet/runtime into cq-sp…
Nov 4, 2020
14fb73d
Update src/libraries/System.Private.CoreLib/src/System/Collections/Co…
alexcovington Nov 5, 2020
729d646
Apply suggestions from code review
alexcovington Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...raries/System.Private.CoreLib/src/System/Collections/Concurrent/ConcurrentQueueSegment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ internal sealed class ConcurrentQueueSegment<T>
internal ConcurrentQueueSegment<T>? _nextSegment; // SOS's ThreadPool command depends on this name
#pragma warning restore 0649

/// <summary>Threshold to spin before allowing threads to sleep when there is contention.</summary>
private const int Sleep1Threshold = 8;

/// <summary>Creates the segment.</summary>
/// <param name="boundedLength">
/// The maximum number of elements the segment can contain. Must be a power of 2.
Expand Down Expand Up @@ -183,7 +186,7 @@ public bool TryDequeue([MaybeNullWhen(false)] out T item)
}

// Lost a race. Spin a bit, then try again.
spinner.SpinOnce(sleep1Threshold: -1);
spinner.SpinOnce(Sleep1Threshold);
}
}

Expand Down Expand Up @@ -244,7 +247,7 @@ public bool TryPeek([MaybeNullWhen(false)] out T result, bool resultUsed)
}

// Lost a race. Spin a bit, then try again.
spinner.SpinOnce(sleep1Threshold: -1);
spinner.SpinOnce(Sleep1Threshold);
}
}

Expand Down Expand Up @@ -301,7 +304,7 @@ public bool TryEnqueue(T item)
}

// Lost a race. Spin a bit, then try again.
spinner.SpinOnce(sleep1Threshold: -1);
spinner.SpinOnce(Sleep1Threshold);
}
}

Expand Down