Skip to content

Conversation

@krwq
Copy link
Member

@krwq krwq commented Nov 18, 2020

Fixes: #44489

@ghost
Copy link

ghost commented Nov 18, 2020

Tagging subscribers to this area: @buyaa-n, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.

Details

Issue Details
Description:

Fixes regression in: #44489

Author: krwq
Assignees: stephentoub, Jozkee, buyaa-n
Labels:

area-System.Xml

Milestone: -

@stephentoub
Copy link
Member

/azp list

@stephentoub
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jeffhandley
Copy link
Member

@krwq Please include these changes into our accumulated list of nullable annotation changes in 6.0.

Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source changes LGTM.

@krwq krwq added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 19, 2020
@krwq
Copy link
Member Author

krwq commented Nov 19, 2020

The failures don't seem to be related, merging

@krwq krwq merged commit a7040b0 into dotnet:master Nov 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Sep 29, 2021
@ericstj ericstj added this to the 6.0.0 milestone Sep 29, 2021
@ericstj ericstj assigned krwq and unassigned stephentoub, jozkee and buyaa-n Sep 30, 2021
@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Xml breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression in SimpleConstructors test inside System.Xml.Linq.TreeManipulation.Tests

6 participants