Skip to content

Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)" #45320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 2 commits into from
Nov 30, 2020
Merged

Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)" #45320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ae831
Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44…
stephentoub Nov 29, 2020
f771872
Add a change to ensure libraries are built/tested
stephentoub Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/crossgen-corelib.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Target Name="Build">
<PropertyGroup>
<!-- Default for using Crossgen2 when not set externally -->
<UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">true</UseCrossgen2>
<UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">false</UseCrossgen2>

<OSPlatformConfig>$(TargetOS).$(TargetArchitecture).$(Configuration)</OSPlatformConfig>
<RootBinDir>$(RepoRoot)\artifacts</RootBinDir>
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal abstract class AsyncOperation
protected static readonly Action<object?> s_availableSentinel = AvailableSentinel; // named method to help with debugging
private static void AvailableSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(AvailableSentinel)} invoked with {s}");

/// <summary>Sentinel object used in a field to indicate the operation has completed.</summary>
/// <summary>Sentinel object used in a field to indicate the operation has completed</summary>
protected static readonly Action<object?> s_completedSentinel = CompletedSentinel; // named method to help with debugging
private static void CompletedSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(CompletedSentinel)} invoked with {s}");

Expand Down