Fix problem with covariant returns with RuntimeType #45381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben Adams has tried to add usage of covariant returns for the RuntimeType as the overriding return type and it has uncovered an ordering issue in the SystemDomain::LoadBaseSystemClasses w.r.t. This change fixes it by shuffling parts of initialization around a bit.
Member
Author
|
cc: @benaadams |
Member
|
I think this should be included in the RuntimeType change if we choose to take it. There is no one right universal order for these. The right order is heavily dependent on the CoreLib implementation details. It is not unusual that this order needs changing when CoreLib implementation details change. |
Member
|
Cherry picked into #45355 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ben Adams has tried to add usage of covariant returns for the
RuntimeType as the overriding return type and it has uncovered an
ordering issue in the SystemDomain::LoadBaseSystemClasses w.r.t.
This change fixes it by shuffling parts of initialization around a bit.
Close #45356