-
Notifications
You must be signed in to change notification settings - Fork 5.3k
renaming clrcompression --> System.IO.Compression.Native
#45713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
…s. Same as Globalization - without `lib` prefix
9da9039 to
3ca8f5c
Compare
3ca8f5c to
cd39845
Compare
d04a11d to
ea583de
Compare
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Unnecessary edit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS did something that I cannot see or undo in the editor. I will revert the whole file in git.
|
Mono changes LGTM. Thanks! |
jkotas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Thanks!!! |
|
FYI: This name change broke an application : #47029. IMHO that app is doing a bad thing, hopefully we'll fix that app. It's not completely unlikely that others might make a similar mistake. Any reason you chose the System.* convention here? |
It was already called |
|
I think we give it a "lib" prefix on those other platforms. |
|
Yes, there is a convention about prefix (lib on Unix, none on Windows) and extensions (.dll, .so, .dylib). They were applied according to platform. There is also prior art in the naming of Actually it still has that name for the purpose of PInvoke targets. We redirect these pinvokes to the implementation linked into coreclr, but a standalone |
I don't think we ever shipped that. System.IO.Compression.Native.dll is the first native binary to use the convention System.*.dll on windows. |
|
We have a lot "System.*.Native." on Unix. The question of "lib" prefix did come up in PR discussions, but it appeared more consistent to not have it on Windows: #45713 (comment) |
Superhost PR follow-up
Re: #44505 (comment)
For the most part a search/replace change.