Move corehost under src/native

[am11]

Commits:

• Move corehost under src/native
• Move content out of cli/ directory
• Update configurations post-move
• Update docs

[ghost]

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Commits:

• Move corehost under src/native
• Move content out of cli/ directory
• Update configurations post-move
• Cleanup trailing whitespaces from changeset
  • Leaving out RapidJson dir
• Update docs

Author:	am11
Assignees:	-
Labels:	area-Host
Milestone:	-

[vitek-karas]

Just nits - I would split the PR into at least two - the move itself and a followup "cleanup".

[am11]

cc @ViktorHofer
This is the only corehost related file I had to keep under src/installer directory, as it is sharing some targets (related to Version/GitSHA1 etc.) with rest of the installer infra. Looks like something that can be shared via src/tasks/installer in the future?

[ViktorHofer]

hmm, src/tasks/* only defines tasks. The repo root's Directory.Build.targets would be used to share targets.

[ViktorHofer]

cc @jkoritzinsky

[am11]

We also have eng/versioning.targets for very similar stuff. (and yup, targets can be converted to tasks. 😉)

[ViktorHofer]

Right, but as a principle we should only create tasks when pure msbuild isn't sufficient.

[jkotas]

https://github.com/dotnet/runtime/pull/45765/files#diff-7e828f345ddcecadc219a5b27948d0f94763928a9ae33de9a6a6b60f3aca685aL120

It is not quite right that this is linking coreclr libs. It would be nice to keep the dependencies linear (e.g. src/native->src/coreclr).

[jkotas]

https://github.com/dotnet/runtime/blob/dac397585824a50852404992ee96b93bae4d91a9/src/native/corehost/apphost/static/CMakeLists.txt#L120

[VSadov]

As I understand this change only moves the files. It does not change how things are built, or tested.

I am not sure we want to do file move as a separate step. We evidently can and it looks like a step to the right direction.
However I wonder if the change achieves enough on its own.

[VSadov]

Changing static host to build in clr partition may be a bit more involved.
Right now the native libs that did not move to the new plan (only Globalization and Compression did) still rely on DLL entry points being re-exported from the final executable.

Because of that the static host picks the corresponding lib files from the libs artefacts.
We do build all necessary libs in clr partition now, but those are expected to be used through "overrider" mechanism and do not have Dll entry points exposed.
It all can be worked around, but it will be easier to wait until all native libs work the same. Then we can start building statichost in clr partition and get rid of coreclr_static.lib
It would be "easier" move then. Not simple :-) In my experience such changes often bring up unexpected troubles.

There is also an issue of testing. If we build static host in clr partition, we probably should test it there as well. This was not yet discussed. Maybe it is a simple matter. I am not sure.

[am11]

Rebased, conflicts resolved. Installer legs on all supported platforms are green.

renames are tricky to review, so I would prefer to keep the PR as simple as possible.

@vitek-karas, made it as simple as possible. Touching only 36 lines fixing paths.
I mainly chose today as other similar "just move" PRs are merged today. Agreed that further changes would be in-place ,and can be done separately from this, much disruptive, move.

[ViktorHofer]

@am11 would you mind once again resolving the conflicts? Thanks a lot for your work.

@vitek-karas @VSadov after the conflicts are resolved could you please give this another look? Thanks

It is not quite right that this is linking coreclr libs. It would be nice to keep the dependencies linear (e.g. src/native->src/coreclr).

@jkotas is this something that should be addressed pre-merge? Maybe I'm misunderstanding but it sounds to me like the cross dependency was already there pre-move.

[jkotas]

@jkotas is this something that should be addressed pre-merge? Maybe I'm misunderstanding but it sounds to me like the cross dependency was already there pre-move.

@jkotas is this something that should be addressed pre-merge?

I am ok with addressing it separately.

[VSadov]

I am working on building host (or at least singlefilehost) in clr partition. It should deal with the dependency that @jkotas mentioned and make coreclr_static.lib unnecessary.

I think moving the files and changing the build are fairly independent. I would be ok with merging this PR.

[am11]

Ops, I pushed after resetting to master and before cherry-picking. 🤦
Can't reopen this PR now., changes are in #48071.