Skip to content

Conversation

@ericstj
Copy link
Member

@ericstj ericstj commented Dec 8, 2020

No description provided.

@ghost
Copy link

ghost commented Dec 8, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: ericstj
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

Feel free to do a quick merge after the allconfigurations leg finished.

@safern
Copy link
Member

safern commented Dec 8, 2020

Last time this happened (with S.D.Common) @ericstj started a conversation about making this less breaking:

One thought here for how we make this less breaking: what if we only turn this on for release branches? Thoughts @joperezr / @Anipik?

I replied

I think that would work as whenever we branch for a preview or a release we turn it off and it will fail to remind us to update this. However, daily built packages could be broken.

#44481 (comment)

Thoughts? I think we should do it for to be less breaking.

@ViktorHofer
Copy link
Member

Thoughts? I think we should do it for to be less breaking.

We will stop harvesting in master sooner than later. I would not invest in any other solution meanwhile.

@ericstj
Copy link
Member Author

ericstj commented Dec 8, 2020

All configurations succeeded: https://dev.azure.com/dnceng/public/_build/results?buildId=912731&view=logs&j=81a0f8c2-d4db-561f-9b8e-3f045280d7fe

@ericstj ericstj merged commit 3424aa7 into dotnet:master Dec 8, 2020
@xtqqczze
Copy link
Contributor

xtqqczze commented Dec 8, 2020

In #45779, there are CI failures, possibly resulting from this PR:

src\libraries\pkg\test\testPackages.proj(214,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.Security.Cryptography.Pkcs is harvesting assets from package version 5.0.0 which is not the latest for that package release. Latest package version from that release is 5.0.1. In order to fix this, run dotnet msbuild System.Security.Cryptography.Pkcs.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true

src\libraries\pkg\test\testPackages.proj(214,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Validation Failed: System.IO.Pipelines is harvesting assets from package version 5.0.0 which is not the latest for that package release. Latest package version from that release is 5.0.1. In order to fix this, run dotnet msbuild System.IO.Pipelines.pkgproj /t:UpdateHarvestVersionOnPackageIndex /p:UpdateStablePackageInfo=true

https://github.com/dotnet/runtime/pull/45779/checks?check_run_id=1519390883

@safern
Copy link
Member

safern commented Dec 8, 2020

In #45779, there are CI failures, possibly resulting from this PR:

@xtqqczze thanks for reaching out. This PR is fixing those failures, it is possible that your build ran before this fix was merged. If you run your pipeline again (by opening/closing, or pushing a new commit) you shouldn't see this failure anymore.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants