Skip to content

Fix crash in SuperPMI getUnmanagedCallConv #46202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BruceForstall merged 1 commit into from
Dec 18, 2020
Merged

Fix crash in SuperPMI getUnmanagedCallConv #46202

BruceForstall merged 1 commit into from
Dec 18, 2020

Conversation

@BruceForstall
Copy link
Contributor

@BruceForstall BruceForstall commented Dec 17, 2020

Fix issue introduced in #45625

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 17, 2020
@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 17, 2020

@dotnet/jit-contrib

@kunalspathak
Copy link
Contributor

kunalspathak commented Dec 17, 2020

Could you please describe what this fix tries to do and if we want it despite #46176?

@BruceForstall
Copy link
Contributor Author

BruceForstall commented Dec 17, 2020

Could you please describe what this fix tries to do and if we want it despite #46176?

#46176 didn't fix the SuperPMI issue.

The original change altered the behavior of the getUnmanagedCallConv API. Either the method handle or the callsig could be null. We were dereferencing the null pointer leading to a crash.

There was an additional copy/paste error where the wrong LWM map was being used.

@BruceForstall BruceForstall merged commit 5ef9a24 into dotnet:master Dec 18, 2020
@BruceForstall BruceForstall deleted the FixSpmiGetUnmanagedCallConv branch December 18, 2020 00:21
@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

+1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BruceForstall @kunalspathak @jkoritzinsky @Dotnet-GitSync-Bot