Skip to content

always try to add the result of getegid to the list returned by getgroups #46302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 2 commits into from
Dec 24, 2020
Merged

always try to add the result of getegid to the list returned by getgroups #46302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
360b674
according to https://man7.org/linux/man-pages/man2/getgroups.2.html i…
adamsitnik Dec 21, 2020
b9525b0
I forgot to re-enable the failing test. I am very stupid
adamsitnik Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,7 @@ private static int CheckUserAndGroupIds(string userId, string groupId, string gr
}

[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/28922", TestPlatforms.AnyUnix)]
public unsafe void TestCheckChildProcessUserAndGroupIds()
public void TestCheckChildProcessUserAndGroupIds()
{
string userName = GetCurrentRealUserName();
string userId = GetUserId(userName);
Expand Down Expand Up @@ -923,7 +922,11 @@ private static unsafe HashSet<uint> GetGroups()
}

// Return this as a HashSet to filter out duplicates.
return new HashSet<uint>(groups.Slice(0, rv).ToArray());
var result = new HashSet<uint>(groups.Slice(0, rv).ToArray());
// according to https://man7.org/linux/man-pages/man2/getgroups.2.html it's not specified
// if this group is included in the list returned by getgroups
result.Add(getegid());
return result;
}
}

Expand Down