Skip to content

disable MainWindow*_GetWithGui_ShouldRefresh_Windows tests for Windows Server Core #46387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 2 commits into from
Dec 24, 2020
Merged

disable MainWindow*_GetWithGui_ShouldRefresh_Windows tests for Windows Server Core #46387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea0585
the MainWindowTitle might have already been initialized
adamsitnik Dec 24, 2020
fa4e38c
disable MainWindow*_GetWithGui_ShouldRefresh_Windows tests for Window…
adamsitnik Dec 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1558,7 +1558,9 @@ public void MainWindowHandle_GetNotStarted_ThrowsInvalidOperationException()
Assert.Throws<InvalidOperationException>(() => process.MainWindowHandle);
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // it needs Notepad
[ConditionalFact(typeof(PlatformDetection),
nameof(PlatformDetection.IsNotWindowsNanoServer), // it needs Notepad
nameof(PlatformDetection.IsNotWindowsServerCore))] // explained in https://github.com/dotnet/runtime/pull/44972
[OuterLoop("Pops UI")]
[PlatformSpecific(TestPlatforms.Windows)]
public void MainWindowHandle_GetWithGui_ShouldRefresh_Windows()
Expand Down Expand Up @@ -1591,7 +1593,9 @@ public void MainWindowHandle_GetWithGui_ShouldRefresh_Windows()
}
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // it needs Notepad
[ConditionalFact(typeof(PlatformDetection),
nameof(PlatformDetection.IsNotWindowsNanoServer), // it needs Notepad
nameof(PlatformDetection.IsNotWindowsServerCore))] // explained in https://github.com/dotnet/runtime/pull/44972
[OuterLoop("Pops UI")]
[PlatformSpecific(TestPlatforms.Windows)]
public void MainWindowTitle_GetWithGui_ShouldRefresh_Windows()
Expand All @@ -1603,8 +1607,6 @@ public void MainWindowTitle_GetWithGui_ShouldRefresh_Windows()
{
try
{
Assert.Equal(string.Empty, process.MainWindowTitle);

for (int attempt = 0; attempt < 50; ++attempt)
{
process.Refresh();
Expand Down