Fixed StringSegment Equals/Compare/StartsWith/EndsWith inconsistencies #46412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsFixes #39140 This is a continuation from: #39853 I am slightly unsure what scenario could lead to needing to fallback to The tests were taken verbatim from #39853 I've made a couple style changes to other parts of the StringSegment file, I'll remove them if undesired. /cc: @GrabYourPitchforks
|
Member
|
There's already an active PR for this: #45022 |
Contributor
Author
Oh woops, I'll close this 😅 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39140
This is a continuation from: #39853
I am slightly unsure what scenario could lead to needing to fallback to
string.Comparein regards tonullre: #39853 (comment)The tests were taken verbatim from #39853
I've made a couple style changes to other parts of the StringSegment file, I'll remove them if undesired.
/cc: @GrabYourPitchforks