Skip to content

Fix macOS arm64 signature corruption at install #46452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
janvorli wants to merge 1 commit into from
Closed

Fix macOS arm64 signature corruption at install #46452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/ToolBox/superpmi/superpmi-shim-collector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,4 @@ else()
_install (FILES $<TARGET_PDB_FILE:superpmi-shim-collector> DESTINATION PDB)
endif(CLR_CMAKE_HOST_UNIX)

_install (TARGETS superpmi-shim-collector DESTINATION .)
_install (PROGRAMS $<TARGET_FILE:superpmi-shim-collector> DESTINATION .)
2 changes: 1 addition & 1 deletion src/coreclr/ToolBox/superpmi/superpmi-shim-counter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ else()
_install (FILES $<TARGET_PDB_FILE:superpmi-shim-counter> DESTINATION PDB)
endif(CLR_CMAKE_HOST_UNIX)

_install (TARGETS superpmi-shim-counter DESTINATION .)
_install (PROGRAMS $<TARGET_FILE:superpmi-shim-counter> DESTINATION .)
2 changes: 1 addition & 1 deletion src/coreclr/ToolBox/superpmi/superpmi-shim-simple/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ else()
_install (FILES $<TARGET_PDB_FILE:superpmi-shim-simple> DESTINATION PDB)
endif(CLR_CMAKE_HOST_UNIX)

_install (TARGETS superpmi-shim-simple DESTINATION .)
_install (PROGRAMS $<TARGET_FILE:superpmi-shim-simple> DESTINATION .)
2 changes: 1 addition & 1 deletion src/installer/corehost/cli/fxr/standalone/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ if(CLR_CMAKE_HOST_UNIX)
set_property(TARGET hostfxr APPEND_STRING PROPERTY LINK_DEPENDS ${EXPORTS_FILE})
endif(CLR_CMAKE_HOST_UNIX)

install_with_stripped_symbols(hostfxr TARGETS corehost)
install_with_stripped_symbols(hostfxr PROGRAMS corehost)
target_link_libraries(hostfxr libhostcommon)
2 changes: 1 addition & 1 deletion src/installer/corehost/cli/hostpolicy/standalone/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ if(CLR_CMAKE_HOST_UNIX)
set_property(TARGET hostpolicy APPEND_STRING PROPERTY LINK_DEPENDS ${EXPORTS_FILE})
endif(CLR_CMAKE_HOST_UNIX)

install_with_stripped_symbols(hostpolicy TARGETS corehost)
install_with_stripped_symbols(hostpolicy PROGRAMS corehost)
target_link_libraries(hostpolicy libhostcommon)
4 changes: 2 additions & 2 deletions src/installer/corehost/cli/nethost/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ endif(WIN32)
install(FILES ../coreclr_delegates.h DESTINATION corehost)
install(FILES ../hostfxr.h DESTINATION corehost)
install(FILES nethost.h DESTINATION corehost)
install_with_stripped_symbols(nethost TARGETS corehost)
install_with_stripped_symbols(nethost PROGRAMS corehost)

# Only Windows creates a symbols file for static libs.
if (WIN32)
install_with_stripped_symbols(libnethost TARGETS corehost)
else()
install(TARGETS libnethost DESTINATION corehost)
endif(WIN32)
endif(WIN32)
2 changes: 1 addition & 1 deletion src/installer/corehost/cli/test/mockcoreclr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ endif()

include(../testlib.cmake)

install_with_stripped_symbols(mockcoreclr TARGETS corehost_test)
install_with_stripped_symbols(mockcoreclr PROGRAMS corehost_test)
2 changes: 1 addition & 1 deletion src/installer/corehost/cli/test/mockhostfxr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ set(SOURCES

include(../testlib.cmake)

install_with_stripped_symbols(mockhostfxr_2_2 TARGETS corehost_test)
install_with_stripped_symbols(mockhostfxr_2_2 PROGRAMS corehost_test)
2 changes: 1 addition & 1 deletion src/installer/corehost/cli/test/mockhostpolicy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ set(SOURCES

include(../testlib.cmake)

install_with_stripped_symbols(mockhostpolicy TARGETS corehost_test)
install_with_stripped_symbols(mockhostpolicy PROGRAMS corehost_test)