Skip to content

Conversation

@adamsitnik
Copy link
Member

@danmosemsft Based on what I can see in Kusto my previous PR (#46213) has not solved the problem and this test has failed 140 times since the 25th of December.

I've changed the logic to use RemoveAccessRule instead of adding a new AccessControlType.Deny rule

fixes #46208

…ount:

use RemoveAccessRule instead of adding a new AccessControlType.Deny rule
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jan 4, 2021
@adamsitnik adamsitnik requested a review from danmoseley January 4, 2021 08:19
@ghost
Copy link

ghost commented Jan 4, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

@danmosemsft Based on what I can see in Kusto my previous PR (#46213) has not solved the problem and this test has failed 140 times since the 25th of December.

I've changed the logic to use RemoveAccessRule instead of adding a new AccessControlType.Deny rule

fixes #46208

Author: adamsitnik
Assignees: -
Labels:

area-System.Diagnostics.Process, test enhancement

Milestone: 6.0.0

@adamsitnik
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik
Copy link
Member Author

FWIW this is the only remaining unstable System.Diagnostics.Process test

TestResults 
| where Type startswith "System.Diagnostics.Tests"
| join kind=inner WorkItems on WorkItemId 
| where Finished >= datetime(2020-12-25 0:00:00)
| join kind=inner Jobs on JobId
| where Branch == "refs/heads/master"
| project Started, Duration, Method, QueueName, Message, StackTrace, Arguments, Type, QueueAlias, DockerTag, Type1, Result
| summarize count() by Message, Type, Method, Result, QueueName, StackTrace

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@adamsitnik adamsitnik merged commit e49c9eb into dotnet:master Jan 4, 2021
@adamsitnik adamsitnik deleted the again46208 branch January 4, 2021 17:54
@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: System.Diagnostics.Tests.ProcessStartInfoTests.TestUserCredentialsPropertiesOnWindows

2 participants