Skip to content

Conversation

@danmoseley
Copy link
Member

@danmoseley danmoseley commented Jan 5, 2021

This should fix this timeout

net6.0-Linux-Debug-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
System.Threading.Tasks.TaskCanceledException : A task was canceled.
Stack trace
   at System.Diagnostics.Process.WaitForExitAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs:line 1478
   at System.Diagnostics.Tests.ProcessWaitingTests.WaitAsyncForSignal() in /_/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs:line 490
--- End of stack trace from previous location ---

I notice I already made this exact change on the test above, but the change that added this test probably started before that and finished after it so it never got the increased timeout.

All other timeouts in these tests seem reasonable.

And thus is demonstrated Dans First Law Of Running Tests In Helix -- never underestimate the possibility of hitting the longest tail of possibilities when you run tests sufficiently many times a day.

@ghost
Copy link

ghost commented Jan 5, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

This should fix this timeout

net6.0-Linux-Debug-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
System.Threading.Tasks.TaskCanceledException : A task was canceled.
Stack trace
   at System.Diagnostics.Process.WaitForExitAsync(CancellationToken cancellationToken) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs:line 1478
   at System.Diagnostics.Tests.ProcessWaitingTests.WaitAsyncForSignal() in /_/src/libraries/System.Diagnostics.Process/tests/ProcessWaitingTests.cs:line 490
--- End of stack trace from previous location ---

I notice I already made this exact change on the test above, but the change that added this test probably started before that and finished after it so it never got the increased timeout.

Author: danmosemsft
Assignees: -
Labels:

area-System.Diagnostics.Process

Milestone: -

@danmoseley
Copy link
Member Author

I should have just rolled this into the other PR...

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @danmosemsft !

@adamsitnik adamsitnik added the test-enhancement Improvements of test source code label Jan 5, 2021
@adamsitnik adamsitnik added this to the 6.0.0 milestone Jan 5, 2021
@adamsitnik adamsitnik merged commit 6e111ea into dotnet:master Jan 5, 2021
@danmoseley danmoseley deleted the increasetimeout branch January 5, 2021 15:57
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants