Cleanup, and little improvement for aggressive trimming

[radical]

• The ConfigureTrimming target adds xunit assemblies explicitly, and
  sets TriggerRootAssembly too.

• Looking at the files being linked, some issues noticed:

  • Multiple copies of xunit assemblies, from various locations are
    included. Eg. from System.Buffer.Tests, WasmTestRunner, and
    from the nuget
  • WasmTestRunner is explicitly added as TriggerRootAssembly, but
    it is also passed as an arg for linking, -p link ...
  • xunit.runner.json is incorrectly added to the files to be linked

• Instead:

  • all the files to be published are already in
    ResolvedFileToPublish after AddTestRunnersToPublishedFiles target

  • so, we mark everything for linking,

  • except the main test assembly

  • Also, we use the test runner as a root

  • This way we are explicitly specifying which assemblies to link,
    and which ones to copy

• This reduces the size:

  • 3.1M to 2.6M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/managed/
  • 46M to 31M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/publish/

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• The ConfigureTrimming target adds xunit assemblies explicitly, and
  sets TriggerRootAssembly too.

• Looking at the files being linked, some issues noticed:

  • Multiple copies of xunit assemblies, from various locations are
    included. Eg. from System.Buffer.Tests, WasmTestRunner, and
    from the nuget
  • WasmTestRunner is explicitly added as TriggerRootAssembly, but
    it is also passed as an arg for linking, -p link ...
  • xunit.runner.json is incorrectly added to the files to be linked

• Instead:

  • all the files to be published are already in
    ResolvedFileToPublish after AddTestRunnersToPublishedFiles target

  • so, we mark everything for linking,

  • except:

    • main test assembly
    • and the test runner assembly

  • This way we are explicitly specifying which assemblies to link,
    and which ones to copy

• This reduces the size:

  • 3.1M to 2.6M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/managed/
  • 46M to 31M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/publish/

Author:	radical
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-libraries
Milestone:	-

[ghost]

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• The ConfigureTrimming target adds xunit assemblies explicitly, and
  sets TriggerRootAssembly too.

• Looking at the files being linked, some issues noticed:

  • Multiple copies of xunit assemblies, from various locations are
    included. Eg. from System.Buffer.Tests, WasmTestRunner, and
    from the nuget
  • WasmTestRunner is explicitly added as TriggerRootAssembly, but
    it is also passed as an arg for linking, -p link ...
  • xunit.runner.json is incorrectly added to the files to be linked

• Instead:

  • all the files to be published are already in
    ResolvedFileToPublish after AddTestRunnersToPublishedFiles target

  • so, we mark everything for linking,

  • except:

    • main test assembly
    • and the test runner assembly

  • This way we are explicitly specifying which assemblies to link,
    and which ones to copy

• This reduces the size:

  • 3.1M to 2.6M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/managed/
  • 46M to 31M artifacts/bin/System.Buffers.Tests/net6.0-Release/browser-wasm/AppBundle/publish/

Author:	radical
Assignees:	-
Labels:	arch-wasm, area-Infrastructure-libraries
Milestone:	-

[mdh1418]

Thanks! Looks good to me.

[steveisok]

Excellent! Thanks for trimming even more.

[lewing]

👍