Convert Debugger.Log and Debugger.Launch to QCalls #46617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue Details
|
Member
Author
|
@hoyosjs This will fix the GC hole in Debugger.Log that you have been looking into. There are a few other FCalls that may have the problem too. |
hoyosjs
approved these changes
Jan 6, 2021
Member
hoyosjs
left a comment
hoyosjs
left a comment
There was a problem hiding this comment.
Debugger.Log should've probably always been a QCall given how soon it sets up the helper frame. The other path I don't expect there to be much of a difference.
stephentoub
reviewed
Jan 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.