Mono: use shared StartHelper object #46896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#46390)" This reverts commit 43d0780.
This might happen on netcore if the managed Thread constructor throws an exception before calling InitInternal. In that case the finalizer may see a partially initialized object.
lambdageek
requested review from
EgorBo,
akoeplinger,
lateralusX,
marek-safar,
steveisok and
vargaz
as code owners
ghost
added
the
vargaz
approved these changes
Jan 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #46390 which reverted the Mono parts of #46244.
Fixes #46389
The issue was that the code in #46244 throws in
Threadconstructors before callingInitialize. Which will then cause a finalizer to run on a partially-initialized thread object, which means thatves_icall_System_Threading_InternalThread_Thread_free_internalwill be called with a nullMonoInternalThread:longlivedfield.