Skip to content

Free the second half of double register #46939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunalspathak merged 3 commits into from
Jan 20, 2021
+14 −0
Merged

Free the second half of double register #46939

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d00887d
free the second half of double register
kunalspathak Jan 13, 2021
9d6b279
Take appropriate regmask
kunalspathak Jan 14, 2021
becad8e
revert part of comment
kunalspathak Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/coreclr/jit/lsra.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4933,6 +4933,20 @@ void LinearScan::processBlockStartLocations(BasicBlock* currentBlock)
unassignIntervalBlockStart(getSecondHalfRegRec(targetRegRecord),
allocationPassComplete ? nullptr : inVarToRegMap);
}

// If this is a TYP_FLOAT interval, and the assigned interval was TYP_DOUBLE, we also
// need to update the liveRegs to specify that the other half is not live anymore.
// As mentioned above, for TYP_DOUBLE, the other half will be unassigned further below.
if ((interval->registerType == TYP_FLOAT) &&
((targetRegRecord->assignedInterval != nullptr) &&
(targetRegRecord->assignedInterval->registerType == TYP_DOUBLE)))
{
RegRecord* anotherHalfRegRec = findAnotherHalfRegRec(targetRegRecord);

// Use TYP_FLOAT to get the regmask of just the half reg.
liveRegs &= ~getRegMask(anotherHalfRegRec->regNum, TYP_FLOAT);
}

#endif // TARGET_ARM
unassignIntervalBlockStart(targetRegRecord, allocationPassComplete ? nullptr : inVarToRegMap);
assignPhysReg(targetRegRecord, interval);
Expand Down