Fix building libraries with Ninja. #47344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsFixes #45763 You need to delete the intermediate files and let CMake regenerate them from scratch for this fix to work.
|
akoeplinger
reviewed
Jan 22, 2021
Member
|
I verified that with this change I can build with ninja fully without errors (starting with clean repo). |
jkoritzinsky
commented
Jan 25, 2021
akoeplinger
approved these changes
Jan 26, 2021
Member
Author
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45763
You need to delete the intermediate files and let CMake regenerate them from scratch for this fix to work.