Add test validating against regression in #46469#47643
Merged
eiriktsarpalis merged 2 commits intodotnet:masterfrom Feb 1, 2021
Merged
Add test validating against regression in #46469#47643eiriktsarpalis merged 2 commits intodotnet:masterfrom
eiriktsarpalis merged 2 commits intodotnet:masterfrom
Conversation
|
Tagging subscribers to this area: Issue DetailsSupplementary PR to #47461, adds a unit test validating the behaviour that regressed.
|
eiriktsarpalis
force-pushed
the
add-socketpair-revert-test
branch
from
7fbf792 to
a6cf539
Compare
adamsitnik
approved these changes
Feb 1, 2021
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you for ensuring that the bug is not coming back ;)
eiriktsarpalis
added a commit
to eiriktsarpalis/runtime
that referenced
this pull request
Feb 1, 2021
* Add test validating against regression in dotnet#46469 * fix test bug
Anipik
pushed a commit
that referenced
this pull request
Feb 10, 2021
… (#47644) * Revert "Use socketpair to implement Process.Start redirection" (#47461) * Revert #34861 * reinstate removed test * Update src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> * Add test validating against regression in #46469 (#47643) * Add test validating against regression in #46469 * fix test bug Co-authored-by: Stephen Toub <stoub@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplementary PR to #47461, adds a unit test validating the behaviour that regressed.