[Mono][LLVM] Refactored INTRINS_OVR to include type information and generate add_intrinsic method #47731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naricc
force-pushed
the
naricc/refactor-add-intrinsic
branch
from
11a53b9 to
963ee58
Compare
vargaz
approved these changes
Feb 2, 2021
…erate add_intrinsic
naricc
force-pushed
the
naricc/refactor-add-intrinsic
branch
from
9205640 to
840fdd8
Compare
imhameed
approved these changes
Feb 11, 2021
imhameed
changed the title
Contributor
Author
|
I confirmed that the red installer build was an unrelated failure: #48169 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds type information to the INTRINS_OVR macro, which can then be used to generate the body of the add_intrisic method.
add_intrinsic had cases for some non-overloaded intrinsics, but I do not think they were actually needed, and this change removes them.
This is in draft while I make sure the change doesn't break anything.