[mono] More domain cleanups. #48291
Merged
[mono] More domain cleanups. #48291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
BrzVlad,
CoffeeFlux,
SamMonoRT,
lambdageek and
thaystg
as code owners
ghost
added
the
|
Tagging subscribers to this area: @CoffeeFlux |
vargaz
force-pushed
the
domain-tls2
branch
7 times, most recently
from
ebc71ca to
9a11739
Compare
vargaz
requested review from
DavidKarlas,
lateralusX and
marek-safar
as code owners
…irectly in MonoClass.
The memory in mono-debug.c is now owned by a MonoMemoryManager instead of by a domain.
lambdageek
reviewed
Feb 17, 2021
lambdageek
reviewed
Feb 17, 2021
|
|
||
| MonoArrayHandle | ||
| mono_array_clone_in_domain (MonoDomain *domain, MonoArrayHandle array, MonoError *error); | ||
| mono_array_clone_in_domain (MonoArrayHandle array, MonoError *error); |
Member
There was a problem hiding this comment.
TODO: replace all uses by mono_array_clone_checked, I guess
lambdageek
reviewed
Feb 17, 2021
lambdageek
reviewed
Feb 19, 2021
| DOTNET_Q_ARGS=--nologo -v:q -consoleloggerparameters:NoSummary | ||
|
|
||
| MONO_CONFIG ?=Release | ||
| MONO_CONFIG ?=Debug |
Member
There was a problem hiding this comment.
nit: unrelated. but it also doesn't matter
Contributor
Author
There was a problem hiding this comment.
Will address in a following PR.
lambdageek
approved these changes
Feb 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #48023.