[wasm] Allow assemblies to be skipped for AOTMode=AotInterp #49446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. the targets/props .
.. to allow skipping AOT, per assembly.
This was added earlier to support blazor workload which only uses AOT. But that has since been fixed to correctly use `WasmBuildApp`+`@(WasmNativeAsset)`, so this can be removed.
.. dotnet.wasm . It defaults to `true`.
ghost
added
the
Member
Author
|
This is essentially #48500 minus the renaming of public items/properties. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
lewing
approved these changes
Mar 11, 2021
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
Thanks for separating this out. Added some minor comments but I'm ok with it landing as is.
Member
|
This PR is important to fast track in order to help alleviate longer helix wasm runs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow skipping AOT, per assembly with %(_InternalForceInterpret) metadata
new
$(WasmNativeDebugSymbols)to control symbols fordotnet.wasm(useful only for AOT case), which defaults to truePath handling fixes for AOT builds on windows
add create-packs.proj for setting up packs from a local build, for quick local testing
Also, note that this changes the default
$(AOTMode)toAotInterp