Skip to content

Disable Net5CompatFileStream by default #50166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamsitnik merged 8 commits into from
Apr 8, 2021
Merged

Disable Net5CompatFileStream by default #50166

adamsitnik merged 8 commits into from
Apr 8, 2021

Conversation

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Mar 24, 2021 •
edited
Loading

@adamsitnik adamsitnik added this to the 6.0.0 milestone Mar 24, 2021
@adamsitnik adamsitnik added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 24, 2021
@runfoapp runfoapp bot mentioned this pull request Mar 25, 2021
Closed
@adamsitnik adamsitnik mentioned this pull request Mar 26, 2021
Merged
@adamsitnik adamsitnik force-pushed the disableLegacyFileStream branch from 13bc74e to ae9db76 Compare March 31, 2021 07:00
@adamsitnik
Merge remote-tracking branch 'upstream/main' into disableLegacyFileSt…
da853ba 
…ream

# Conflicts:
#	src/libraries/System.IO.FileSystem/tests/Net5CompatTests/Net5CompatSwitchTests.cs
#	src/libraries/System.Private.CoreLib/src/System/IO/Strategies/FileStreamHelpers.cs
@adamsitnik
reuse the config helper
83afc31
@adamsitnik
Copy link
Member Author

adamsitnik commented Apr 6, 2021

/azp run runtime-libraries-coreclr outerloop-windows

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 6, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@adamsitnik adamsitnik added the breaking-change Issue or PR that represents a breaking API or functional change over a previous release. label Apr 7, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 7, 2021
@adamsitnik adamsitnik removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 7, 2021
@adamsitnik adamsitnik changed the title [DRAFT][NO MERGE] flip the legacy file stream switch Disable Net5CompatFileStream by default Apr 7, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot Apr 7, 2021
@adamsitnik adamsitnik marked this pull request as ready for review April 7, 2021 18:36
@adamsitnik
Copy link
Member Author

adamsitnik commented Apr 7, 2021

@carlossanlop @jozkee @stephentoub everything is ready (please see the PR description for full details), PTAL

@adamsitnik
Copy link
Member Author

adamsitnik commented Apr 7, 2021

/azp run runtime-libraries-coreclr outerloop-windows

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 7, 2021

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 7, 2021
Closed
Closed
@adamsitnik adamsitnik merged commit 8b2ad5b into dotnet:main Apr 8, 2021
@adamsitnik adamsitnik deleted the disableLegacyFileStream branch April 8, 2021 10:40
This was referenced Apr 9, 2021
Closed
Closed
Closed
Closed
@antonfirsov antonfirsov mentioned this pull request Apr 12, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
@adamsitnik
Copy link
Member Author

adamsitnik commented Oct 15, 2021

Breaking change doc: dotnet/docs#24060

@adamsitnik adamsitnik removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@jozkee jozkee jozkee approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

Assignees

@adamsitnik adamsitnik

Labels

area-System.IO breaking-change Issue or PR that represents a breaking API or functional change over a previous release.

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@adamsitnik @stephentoub @jozkee