Skip to content

[wasm] Add targets to run samples #50244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radekdoulik merged 3 commits into from
Apr 8, 2021
Merged

[wasm] Add targets to run samples #50244

radekdoulik merged 3 commits into from
Apr 8, 2021

Conversation

@radekdoulik
Copy link
Member

@radekdoulik radekdoulik commented Mar 25, 2021

Add RunSample and BuildSampleInTree targets.

Mention how to run the samples in the README

@radekdoulik
[wasm] Add targets to run samples
df32701 
Add `RunSample` and `BuildSampleInTree` targets.

Mention how to run the samples in README
@radekdoulik radekdoulik added the arch-wasm WebAssembly architecture label Mar 25, 2021
@radekdoulik radekdoulik requested a review from radical March 25, 2021 15:41
@ghost
Copy link

ghost commented Mar 25, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Add RunSample and BuildSampleInTree targets.

Mention how to run the samples in the README

Author: radekdoulik
Assignees: -
Labels:

arch-wasm
Milestone: -

@ghost ghost added the area-Build-mono label Mar 25, 2021
@radekdoulik radekdoulik requested a review from lewing March 25, 2021 15:42
radical
radical reviewed Apr 7, 2021
View reviewed changes
@radekdoulik radekdoulik requested a review from radical April 7, 2021 19:54
thaystg
thaystg approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@thaystg thaystg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik radekdoulik merged commit c38b7c3 into dotnet:main Apr 8, 2021
@antonfirsov antonfirsov mentioned this pull request Apr 12, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 8, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@thaystg thaystg thaystg approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

No one assigned

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@radekdoulik @radical @thaystg @karelz